fix(release): flip release-plz to registry baseline; re-enable push trigger#389
Merged
Merged
Conversation
…rigger Root cause of 'PR merged, nothing happened': the release-plz push trigger was commented out (workflow_dispatch-only) after the 2026-06-09 re-activation failed 4 consecutive runs, so the #387/#388 merges to main triggered no release-pr run at all. Those failures were structural, not transient: in git_only mode release-plz hardcodes 'cargo package --allow-dirty --workspace' inside the latest-tag worktree (verified with RUST_LOG=debug on 0.3.157), packaging ALL members regardless of release=false config. Never-publish crates with versioned internal deps (uffs-broker -> uffs-broker-protocol) can never resolve from the crates.io index; dropping the version instead fails with 'all dependencies must have a version requirement' -- both directions reproduced locally. Git-only mode can never work on this workspace, and the old 're-enable after the internal crates are published' condition was unsatisfiable (they are never-publish by design). Fix: git_only = false (registry baseline) -- the flip release-plz.toml's own R4 comment block planned for post-R8. With uffs-time + uffs-text v0.5.120 live on crates.io (R8 bootstrap), release-plz downloads the published .crate files as baseline and never invokes the worktree packaging step. Verified locally: 'release-plz update' downloads uffs-text 0.5.120, exits 0, and proposes bumps only when the published crates' files change. Also: re-enabled push: branches: [main]; rewrote the two stale deferral notices in the workflow header as historical records with the resolution trail; added the matching deviation row + R4 dashboard correction in release-automation-plan.md. actionlint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why merges to main were producing no release activity
The release-plz
push: branches: [main]trigger was commented out (workflow_dispatch-only) after the 2026-06-09 re-activation failed 4 consecutive runs — so #387/#388 triggered nothing.Root cause (structural, reproduced locally)
In
git_onlymode release-plz hardcodescargo package --allow-dirty --workspacein the latest-tag worktree, packaging all members regardless ofrelease = false. Never-publish crates with versioned internal deps (uffs-broker→uffs-broker-protocol) can never resolve from the crates.io index; dropping the version fails with 'all dependencies must have a version requirement'. Both directions reproduced locally — git-only mode can never work on this workspace.Fix
git_only = false— registry-baseline mode, the exact fliprelease-plz.toml's R4 comment block planned for post-R8. With uffs-time + uffs-text v0.5.120 live on crates.io, release-plz downloads the published .crate files as baseline; the broken packaging step is never invoked. Verified locally:release-plz updateexits 0, downloads uffs-text 0.5.120 as baseline, proposes bumps only when published-crate files change.Also re-enables the push trigger, rewrites the stale deferral notices as historical records, and adds the §8.1 deviation row + R4 dashboard correction.
Note
This
fix:commit doesn't touchcrates/uffs-time/uffs-textfiles, so merging it will exercise the release-pr job in its no-op path (clean green run, no release PR) — itself a useful validation.